Item9275: configure crashes and is unusable when given bad cfg/spec

pencil
Priority: Normal
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component:
Branches:
Reported By: SvenDowideit
Waiting For:
Last Change By: CrawfordCurrie
which, if caused to someone's foswiki because they installed a contrib, or worse, several, will be really really frustrating

Could not load type T: Can't locate Foswiki/Configure/Types/T.pm in @INC (@INC contains: /home/dowideit/foswiki/core/lib /home/dowideit/foswiki/core/lib . /etc/perl /usr/local/lib/perl/5.10.0 /usr/local/share/perl/5.10.0 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl /home/dowideit/foswiki/core/lib/CPAN/lib//arch /home/dowideit/foswiki/core/lib/CPAN/lib//5.10.0/x86_64-linux-gnu-thread-multi /home/dowideit/foswiki/core/lib/CPAN/lib//5.10.0 /home/dowideit/foswiki/core/lib/CPAN/lib/ /home/dowideit/foswiki/core/lib/CPAN/lib//arch /home/dowideit/foswiki/core/lib/CPAN/lib//5.10.0/x86_64-linux-gnu-thread-multi /home/dowideit/foswiki/core/lib/CPAN/lib//5.10.0 /home/dowideit/foswiki/core/lib/CPAN/lib/) at (eval 2032) line 2.
BEGIN failed--compilation aborted at (eval 2032) line 2.
 at /home/dowideit/foswiki/core/lib/Foswiki/Configure/Type.pm line 46
   Foswiki::Configure::Type::load('T') called at /home/dowideit/foswiki/core/lib/Foswiki/Configure/Value.pm line 98
   Foswiki::Configure::Value::getType('Foswiki::Configure::Value=HASH(0xd1c138)') called at /home/dowideit/foswiki/core/lib/Foswiki/Configure/UIs/Value.pm line 39
   Foswiki::Configure::UIs::Value::renderHtml('Foswiki::Configure::UIs::Value=HASH(0x2389d38)', 'Foswiki::Configure::Value=HASH(0xd1c138)', 'Foswiki::Configure::UIs::Root=HASH(0xcae2a8)') called at /home/dowideit/foswiki/core/lib/Foswiki/Configure/UIs/Section.pm line 174
   Foswiki::Configure::UIs::Section::_renderValues('Foswiki::Configure::UIs::Section=HASH(0x2263af0)', 'Foswiki::Configure::Section=HASH(0x93f960)', 'Foswiki::Configure::UIs::Root=HASH(0xcae2a8)') called at /home/dowideit/foswiki/core/lib/Foswiki/Configure/UIs/Section.pm line 60
   Foswiki::Configure::UIs::Section::renderHtml('Foswiki::Configure::UIs::Section=HASH(0x2263af0)', 'Foswiki::Configure::Section=HASH(0x93f960)', 'Foswiki::Configure::UIs::Root=HASH(0xcae2a8)', '') called at /home/dowideit/foswiki/core/lib/Foswiki/Configure/UIs/Root.pm line 111
   Foswiki::Configure::UIs::Root::endVisit('Foswiki::Configure::UIs::Root=HASH(0xcae2a8)', 'Foswiki::Configure::Section=HASH(0x93f960)') called at /home/dowideit/foswiki/core/lib/Foswiki/Configure/Section.pm line 93
   Foswiki::Configure::Section::visit('Foswiki::Configure::Section=HASH(0x93f960)', 'Foswiki::Configure::UIs::Root=HASH(0xcae2a8)') called at /home/dowideit/foswiki/core/lib/Foswiki/Configure/Section.pm line 90
   Foswiki::Configure::Section::visit('Foswiki::Configure::Section=HASH(0xc9ae10)', 'Foswiki::Configure::UIs::Root=HASH(0xcae2a8)') called at /home/dowideit/foswiki/core/lib/Foswiki/Configure/Section.pm line 90
   Foswiki::Configure::Section::visit('Foswiki::Configure::Root=HASH(0x941fd0)', 'Foswiki::Configure::UIs::Root=HASH(0xcae2a8)') called at /home/dowideit/foswiki/core/lib/Foswiki/Configure/UIs/Root.pm line 73
   Foswiki::Configure::UIs::Root::createUI('Foswiki::Configure::UIs::Root=HASH(0xcae2a8)', 'Foswiki::Configure::Root=HASH(0x941fd0)', 'Foswiki::Configure::Valuer=HASH(0x940ae8)') called at configure line 775
   Foswiki::_actionConfigure() called at configure line 463
   Foswiki::_dispatchContents() called at configure line 433

is this another crash caused by recent changes - previously we were hiding the issue completely?

I think we should default to the UNKNOWN type, but amend that to raise an ERROR in the UI, and to inform what the problem is.

Crawford hopefully has a better idea how this could be achieved..

-- SvenDowideit - 08 Jul 2010

Hokay, no more crash, and it generates a shouty message in the UI if something is wrong.

-- CrawfordCurrie - 09 Jul 2010

 

ItemTemplate edit

Summary configure crashes and is unusable when given bad cfg/spec
ReportedBy SvenDowideit
Codebase trunk
SVN Range
AppliesTo Engine
Component
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:f0d4005ec916 distro:7e60bae32fd3
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r3 - 09 Jul 2010, CrawfordCurrie
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy