You are here: Foswiki>Tasks Web>Item9509 (21 Aug 2010, GeorgeClark)Edit Attach

Item9509: Rendering differences between 1.0.x and 1.1

pencil
Priority: Urgent
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component:
Branches:
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
See also Item9432 and Item9492

For skin=text;conttentype=text/plain, Trunk leaves <nop> and <noautolink> tags in place. Release removes them.

-- GeorgeClark - 20 Aug 2010

The problem appears to be a change in the _prepare routine of Foswiki/UI/View.pm. The line: $text =~ s/( ?) *<\/?(nop|noautolink)\/?>\n?/$1/gois; was removed.

http://trac.foswiki.org/changeset/4065/trunk/core/lib/Foswiki/UI/View.pm

-- GeorgeClark - 20 Aug 2010

Micha, can you comment on why you removed the code that stripped noautolink and nop from View::_prepare ? That seems to be the root cause of the JQuery problem in Item9492. I've got a unit test to check in that will verify the issue but need feedback on how to fix. Just put back the removed code, or is there some other issue that triggered it's removal?

-- GeorgeClark - 20 Aug 2010

Well compare http://translate.foswiki.org/System/JQueryAjaxHelper?section=user;skin=text&q=m&limit=10&timestamp=1282306571573&contenttype=text/plain with http://translate.foswiki.org/System/JQueryAjaxHelper?section=user;skin=text&q=m&limit=10&timestamp=1282306571573

Removing the contenttype url param was the quickest possible fix as the content type isn't relevant for further processing the result in this case.

I am not sure who or why nop and noautolink are disabled when is contenttype=text/plain ... nor can I possibly think of any advantage of leaving them in. So that's possibly an error.

-- MichaelDaum - 20 Aug 2010
 

ItemTemplate edit

Summary Rendering differences between 1.0.x and 1.1
ReportedBy GeorgeClark
Codebase trunk
SVN Range
AppliesTo Engine
Component
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:87186f250a40 distro:a014be2c075b
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r9 - 21 Aug 2010, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy