Priority: Enhancement
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component:
Branches:
Links with class
foswikiPopUp
should open a new window. No longer works (since the javascript refactoring?).
--
ArthurClemens - 21 Aug 2010
Yeah; I got rid of foswikiWindow, which was being unloaded unconditionally despite only being used on a small fraction of pages.
We can bring it back, but I can't help feeling there must be a better (jQuery) solution for popups - I didn't have time to explore it.
--
CrawfordCurrie - 22 Aug 2010
When you analyse how it's used, it makes sense to simply embed the code in the pattern skin JS - it's tiny.
--
CrawfordCurrie - 23 Aug 2010
Michael Daum thinks it is not a good idea to scan every page for possible
foswikiPopUp
links.
Sven proposes to use a macro like
POPUP
(that is used in
JSPopupPlugin).
I think it is a good idea. The macro would become part of the distributed macros. Calling it would make sure the right js is loaded.
What about
NEWWINDOW
?
--
ArthurClemens - 24 Aug 2010
I have implemented
POPUPWINDOW
for JQueryPlugin.
But my concern is that if the plugin is not enabled, you will see the raw macro, and if {PopUpWindow}
is not activated, you will see nothing. There should be a fallback to a normal link. I think that can only happen if POPUPWINDOW
has a default implementation in core.
--
ArthurClemens - 03 Sep 2010
Changed topic title from "foswikiPopUp links no longer work".
Added a line about
POPUPWINDOW{}
in the release notes.
--
ArthurClemens - 04 Sep 2010
Arthur, The nested
MAKETEXT inside a
MAKETEXT is not working for me in
templates/validate.tmpl
I don't get the link or popup window. Just the text
If you are unsure what this means, read: . without any link.
I believe that we should also ship this information with Foswiki instead of referencing Foswiki.org.
--
GeorgeClark - 05 Sep 2010
The bug is not caused by nested
MAKETEXT, but by
LocalSite.cfg
that is not automatically updated with a new
Config.spec
file update. We ought to find a solution for this, because Configure doesn't give a hint that something needs to be updated, and even when Saving (no changes) no feedback is given.
So this item is still done.
For putting the validation info screen in the distro please open another Task.
--
ArthurClemens - 05 Sep 2010