You are here: Foswiki>Tasks Web>Item9949 (09 Mar 2011, GeorgeClark)Edit Attach

Item9949: Fix documentation for META:FILEATTACHMENT movedfrom and movedto describing they contain web.topic.attachment

pencil
Priority: Normal
Current State: Closed
Released In: 1.1.2
Target Release: patch
Applies To: Engine
Component: Foswiki::UI::Manage Foswiki::Render
Branches:
Reported By: BryanThale
Waiting For:
Last Change By: GeorgeClark
The documentation in MetaData says the movedfrom and movedto fields of META:FILEATTACHMENT should contain the web.topic. However, after moving an attachment, I see:

META:FILEATTACHMENT{name="foswiki.gif" attachment="foswiki.gif" attr="" comment="Attachment to Sandbox.Test1 Test1 /Sandbox/Test1" date="1288841379" moveby="bthale" movedto="Sandbox.Test2.foswiki.gif" movedwhen="1288841433" movefrom="Sandbox.Test1.foswiki.gif" path="foswiki.gif" size="1013" stream="IO::File=GLOB(0xcdc414c)" tmpFilename="/tmp/mc_AtJqC_Y" user="bthale" version="1"}

Is this a bug in the code or the documentation?

-- BryanThale - 04 Nov 2010

In the user interface you can change both web, topic and attachment name.

If the movefrom and moveto would only contain the web and topic, and not the filename, it would mean that the former filename would not be available.

So I would say - let is correct the documentation.

I have checked 1.1.1 and it also includes the filename.

-- KennethLavrsen - 04 Nov 2010

Fixed docu

I assume it was on MetaData that had a problem

-- KennethLavrsen - 04 Nov 2010

Is there going to be an issue with attachment filenames that contain dots? i.e., how is Web.Topic.Attachment.R1.V2.gif going to be interpreted? What delimits webs, subwebs, topics, filenames, and extensions in this value? Are subwebs guaranteed to use slashes so the first dot separates Web and Topic and the second dot separates Topic and Attachment name which is the remainder of the string?

-- BryanThale - 04 Nov 2010

There is also a discrepancy with the moveddate field, the code generates movedwhen instead.

-- BryanThale - 04 Nov 2010

Remember to reopen a bug or better - make a new.

Comments on closed bugs have a 50-99% risk of being lost. It is only because I happen to click on the items changed today I see this

-- KennethLavrsen - 04 Nov 2010

I didn't notice it before, but movefrom is supposed to be movedfrom as well.

-- BryanThale - 05 Nov 2010

I've fixed the moveddate issue under the general documentation task Item9986 for Release 1.1.3 - changing this back to closed.

-- GeorgeClark - 09 Mar 2011
 

ItemTemplate edit

Summary Fix documentation for META:FILEATTACHMENT movedfrom and movedto describing they contain web.topic.attachment
ReportedBy BryanThale
Codebase 1.1.1, 1.0.9
SVN Range
AppliesTo Engine
Component Foswiki::UI::Manage Foswiki::Render
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:e14e3bb88e7c distro:8a5cee599268
TargetRelease patch
ReleasedIn 1.1.2
Topic revision: r9 - 09 Mar 2011, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy