Item11828: Abstract and core-ify EditRowPlugin's table parser and object model

Priority: Urgent
Current State: Closed
Released In: 1.2.0
Target Release: minor
Applies To: Engine
Branches: trunk
Reported By: CrawfordCurrie
Waiting For:
Last Change By: CrawfordCurrie
See DemandParseTables

-- CrawfordCurrie - 07 May 2012

distro:614cfb8d854f broke RenderFormTests::test_render_for_edit (not to be annoying, just working through test failures before I start some work of my own)

-- PaulHarvey - 16 Jun 2012

InitFormTests also fail, but I found the problem - mis-numbered indices

-- PaulHarvey - 16 Jun 2012

So now it's just TableParserTests that fail.

-- PaulHarvey - 16 Jun 2012

The failures seem to be related to the early_line changes, as well as Foswiki::Form::_parseFormDefinition using the table parser directly instead of using one of the reader classes. The event handler there isn't up to date with regards to the latest changes related to this early_line thingy. It then never gets an open_table event

The parser seems to stumble over multiline %MACROS calling them "unbalanced" which isn't quite true. Not sure whether that influences the rest of the process.

Aaargh. There was a lonely non-opening </verbatim> tag on the form definition page that made the parser go nuts.

-- MichaelDaum - 27 Jun 2012

By my testing this is OK now.

-- CrawfordCurrie - 23 Jan 2013

Topic revision: r12 - 23 Jan 2013, CrawfordCurrie
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy