Item13080: Configuration setting errors

There appears to be some recent regression in configure.

Some config parameters are getting extra quoting when set from wizard.

• Start with email unconfigured
• Fill in 4 parameters and press Autoconfigure button
  • {WebMasterEmail}
  • {SMTP}{MAILHOST}
  • {SMTP}{Username}
  • {SMTP}{Password}
• Auto-configure runs and reports configuration settings:

{SMTP}{MAILHOST} = 'my.mail.server:587'
{Email}{MailMethod} = 'Net::SMTP (STARTTLS)'
{SMTP}{SENDERHOST} = 'my.wiki.server'

• Note that the quotes are actually written to the configuration, which is invalid:

$Foswiki::cfg{Email}{MailMethod} = '\'Net::SMTP (STARTTLS)\'';
$Foswiki::cfg{SMTP}{MAILHOST} = '\'my.mail.server:587\'';
$Foswiki::cfg{SMTP}{SENDERHOST} = '\'my.wiki.server\'';

I've tracked the root cause down using git bisect:

gac@cardinal: /var/www/foswiki/distro ((no branch, bisect started on master))$ git bisect good
e80d705e240a80345e6bb20cfa8971792873ee6a is the first bad commit
commit e80d705e240a80345e6bb20cfa8971792873ee6a
Author: crawford <git@c-dot.co.uk>
Date:   Thu Oct 16 20:23:12 2014 +0100

    Item12952: fixes for extension installation and handling of perl values

:040000 040000 e03b67a012b11a8037642d628446dc9c4cfa9c0c 4c5596d78e6e86148da86db37cf60cc6524d2f76 M      ConfigurePlugin
:040000 040000 f2ba10ac15c2b83b183f86afe50d84148c346e40 4dc3bd379889ef1b406036bb5d5723eacfa7a502 M      UnitTestContrib
:040000 040000 5467893e7632e539930e8a8399003f5845b8901e d6f2d01bc9b03795785d34bddf9de3b6ca504653 M      core

Regexes are growing on each save:

• ConfigureFilter initially entered as ^(AaaronBBB|JoeUser|BaseUserMapping_333)$
• Saved as: $Foswiki::cfg{ConfigureFilter} = '(?^:^(AaaronBBB|JoeUser|BaseUserMapping_333)$)';
• Add a name AaaronBBB|JoeUser|FredFlint and save the config
• Save report shows:

{ConfigureFilter}    '(?^:^(AaaronBBB|JoeUser|BaseUserMapping_333)$)'    qr/(?^:(?^:^(AaaronBBB|JoeUser|FredFlint|BaseUserMapping_333)$))/

• Saved as: $Foswiki::cfg{ConfigureFilter} = '(?^:(?^:^(AaaronBBB|JoeUser|FredFlint|BaseUserMapping_333)$))';

An enclosing (?^: ... ) is added on each save iteration

Enable checkboxes don't always stick.

Still working on a recreation. I have not been able to recreate this

This is what appeared to happen. Again, I can't recreate.

• Pseudo-installed
• Ran bin/configure, had to clicky the "set default" for each field
• Saved config
• Clicked "Enable" for the FileRolling and Screen loggers
• Saved config

They were actually not enabled in the config, so the logger wasn't writing anything.

---

There are three problems reported in this task, which makes it rather difficult to comment on.

Some config parameters are getting extra quoting when set from wizard - I cannot reproduce this. The mail configuration wizard works fine for me. Procedure:

• Remove LocalSite.cfg to for bootstrap
• Run configure GUI
• Add settings for {WebMasterEmail} * {SMTP}{MAILHOST} * {SMTP}{Username} * {SMTP}{Password}
• Click Autoconfigure

I get back a report that says autoconfigure worked, and a prompt to save 7 changes. I save them, and get an LSC that has all the correct values.

Regexes are growing on each save - fixed

Enable checkboxes don't always stick - as far as I can tell it's all working correctly.

-- CrawfordCurrie - 03 Dec 2014