You are here: Foswiki>Tasks Web>Item14844 (30 May 2019, GeorgeClark)Edit Attach

Item14844: mistake in System.PatternSkinCssCookbookSidebarToggle

pencil
Priority: Normal
Current State: New
Released In: 2.1.7
Target Release: patch
Applies To: Web Site
Component:
Branches:
Reported By: StijnBousard
Waiting For:
Last Change By: GeorgeClark
In the current (v2.1.6) PatternSkinCssCookbookSidebarToggle, we read:

This line loads the extra style definition:
   * Set USERSTYLEURL = %PUBURLPATH{topic="%SYSTEMWEB%.PatternSkinCssCookbookSidebarToggle" "SidebarToggle.css"}%

According to me, this must be:

This line loads the extra style definition:
   * Set USERSTYLEURL = %PUBURLPATH%/%SYSTEMWEB%/PatternSkinCssCookbookSidebarToggle/SidebarToggle.css


That's the new "canonical" form attachment links. Concatenation of path elements will fail in some cases of Unicode characters. Use of the macro format works fine. Demonstrated here:

Canonical: %PUBURLPATH{topic="%SYSTEMWEB%.PatternSkinCssCookbookSidebarToggle" "SidebarToggle.css"}% /pub/System/PatternSkinCssCookbookSidebarToggle/SidebarToggle.css
Concatenated: %PUBURLPATH%/%SYSTEMWEB%/PatternSkinCssCookbookSidebarToggle/SidebarToggle.css /pub/System/PatternSkinCssCookbookSidebarToggle/SidebarToggle.css

-- Main.GeorgeClark - 16 May 2019 - 06:47


The canonical form made the SidebarToggle fail on my old/new hosting as long as wasn't able use my domain name (http://83.172.180.136/~boossybe/wiki): Chrome Developer Tools console error:
GET http://83.172.180.136/pub/System/PatternSkinCssCookbookSidebarToggle/SidebarToggle.css net::ERR_ABORTED 404 (Not Found)
=> Must be: http://83.172.180.136/~boossybe/wiki/pub/System/PatternSkinCssCookbookSidebarToggle/SidebarToggle.css
default url host: http://83.172.180.136
script url path: /~boossybe/wiki/bin
script url path for view: /~boossybe/wiki/bin/view
pub url path: /~boossybe/wiki/pub

The canonical form works correctly when I'm able to use my domain name:
default url host: http://wiki.boossy.be
script url path: /bin
script url path for view: /bin/view
pub url path: /pub

-- Main.StijnBousard - 29 May 2019 - 16:01

I can't recreate this right now, but I'm reopening it until it's completely investigated.

-- GeorgeClark - 30 May 2019
 
Topic revision: r4 - 30 May 2019, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy